Launcher truncate options & related refactors #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � src/gtk_helpers.rs � src/modules/music/mod.rs
JakeStanger
force-pushed
the
feat/launcher-truncate
branch
from
0694f98 to
da13b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new options to the
launchermodule:truncate- applies to application names whenshow_namesis enabled. This defaults tomode = "end".truncate_popup- applies to window names within the group popup. This defaults tomode = "end" max_length = 25and replaces the previous hard-coded implementation.The
truncate.modeoption can now also be explicitly set tooffeverywhere it's taken. This is the same as leaving it asnullin most cases for now, but I will be reviewing the other modules to ensure they too are using a sensible default.The truncation code has also been refactored.
Resolves partially #633