-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .urgent
workspace css class
#735
Conversation
56054ab
to
177e85f
Compare
177e85f
to
1a4e432
Compare
1a4e432
to
74e6c90
Compare
11a8f60
to
97f91a7
Compare
Revised everything now. Fixed a typo in the docs, remove the |
Thanks for this. This looks good, I'll test it when I can and will approve once I've confirmed it working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
97f91a7
to
afe534c
Compare
Cheers, this looks good. The next release will be bugfix-only, so I'm going to hold off merging for the time being. Once #748 merges, this will need to be slightly reworked, which is poor planning on my part. I'll pick that up to avoid creating you too much more work. |
Allow highlighting a workspace which contains a window that triggered a urgent event, i.e., requests attention. In my case, I see it happens when I clink a link and it opens in a new tab on firefox, and when displaying a
BEL
character in some terminal emulators (at least in alacritty).You can test it by running
sleep 1 && tput bel
in alacritty, and switching to another workspaces before the sleep expires.
I implemented it for both Sway and Hyprland. Sway keep track of a
urgent
flag for each client, and notify ironbar about changes. Hyprland or the other hand only contains a urgent event that triggers once, so I clean the urgent state of a workspace whenever it is focused.