Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .urgent workspace css class #735

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

Rodrigodd
Copy link
Contributor

Allow highlighting a workspace which contains a window that triggered a urgent event, i.e., requests attention. In my case, I see it happens when I clink a link and it opens in a new tab on firefox, and when displaying a BEL character in some terminal emulators (at least in alacritty).

You can test it by running

sleep 1 && tput bel

in alacritty, and switching to another workspaces before the sleep expires.

I implemented it for both Sway and Hyprland. Sway keep track of a urgent flag for each client, and notify ironbar about changes. Hyprland or the other hand only contains a urgent event that triggers once, so I clean the urgent state of a workspace whenever it is focused.

src/modules/workspaces.rs Outdated Show resolved Hide resolved
@Rodrigodd Rodrigodd force-pushed the feat/urgent branch 2 times, most recently from 11a8f60 to 97f91a7 Compare September 27, 2024 14:21
@Rodrigodd
Copy link
Contributor Author

Revised everything now. Fixed a typo in the docs, remove the dbg! usage, and fixed some non-formated code inside a macro.

@Rodrigodd Rodrigodd requested a review from yavko September 27, 2024 14:22
@JakeStanger
Copy link
Owner

Thanks for this. This looks good, I'll test it when I can and will approve once I've confirmed it working as expected.

Copy link
Contributor

@yavko yavko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@JakeStanger
Copy link
Owner

Cheers, this looks good.

The next release will be bugfix-only, so I'm going to hold off merging for the time being. Once #748 merges, this will need to be slightly reworked, which is poor planning on my part. I'll pick that up to avoid creating you too much more work.

@JakeStanger JakeStanger added this to the 0.17.0 milestone Nov 4, 2024
@JakeStanger JakeStanger merged commit 9c13e53 into JakeStanger:master Nov 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants