feat(launcher): open new window on middle-click #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree this makes sense to add. Could you just add a quick sentence to the docs to explain the new behaviour please? Thanks! |
BowDown097
commented
Dec 15, 2024
|
LGTM, I'll give this a quick test when I can & approve if all working. Cheers |
|
There are some bugs around the behaviour of this, but they're related to gtk-launch and long-standing issues with the launcher. I'll need to address those at a later date, but I think as it stands this PR works as well as it can within the system so I'll merge. Cheers again. |
JakeStanger
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the (now closed) #813 for more info.