Merge pull request #20 from JakubPluta/analyst-report

Analyst report
JakubPluta · Mar 30, 2024 · 04d4cdc · 04d4cdc
2 parents 781f0df + 65b82cf
commit 04d4cdc
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/pytests.yml b/.github/workflows/pytests.yml
@@ -34,7 +34,7 @@ jobs:
  run: |
  source .venv/bin/activate
  pip install requests
- pytest --cov=./ --cov-report=xml -vv -ss
+ pytest --cov=./ --cov-report=xml -vv -ss -k "not test_functional"
  echo "tests finished"
  - name: Upload coverage to Codecov
  uses: codecov/codecov-action@v3

diff --git a/etfpy/analytics/tabular_etf.py b/etfpy/analytics/tabular_etf.py
@@ -116,6 +116,7 @@ def info(self):
  "Niche",
  "Strategy",
  "Weighting Scheme",
+ "Analyst Report",
  ]
  data = {
  k[:-1] if k.endswith(":") else k: v

diff --git a/etfpy/client/etf_client.py b/etfpy/client/etf_client.py
@@ -290,7 +290,4 @@ def _basic_info(self) -> Dict:
  basic_information.update(self._trading_data())
  basic_information.update(self._asset_categories())
  basic_information.update(self._factset_classification())
- if "Analyst Report" in basic_information:
- basic_information.pop("Analyst Report")
-
  return basic_information
diff --git a/tests/test_etf_client.py b/tests/test_etf_client.py
@@ -39,6 +39,7 @@ def test_basic_info():
  "Niche": "Broad-based",
  "Strategy": "Active",
  "Weighting Scheme": "Proprietary",
+ "Analyst Report": "https://etfdb.com/advisor_reports/JEPY/",
  }