Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid sensor address #41

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

mirkancal
Copy link
Contributor

Encountered an issue with connecting to a Polar H10 sensor due to its UUID cd818013-47f2-e83e-dc7c-05f6a924a5ad being incorrectly marked as invalid by the existing regex in the library.

@JanCBrammer
Copy link
Owner

Thanks for the PR @mirkancal!
Looks like the regex for validating UUIDs continues its history of becoming more lenient over time:

commit regex
72e3f92 [0-9a-f]{8}-[0-9a-f]{4}-[0-5][0-9a-f]{3}-[089ab][0-9a-f]{3}-[0-9a-f]{12}$
3b96e2b [0-9a-f]{8}-[0-9a-f]{4}-[0-5][0-9a-f]{3}-[0-9a-f]{4}-[0-9a-f]{12}$
a2c3d4d [0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}

For context and future reference I'm linking #26.

@JanCBrammer JanCBrammer merged commit afdc960 into JanCBrammer:main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants