Skip to content

Commit

Permalink
update NEWS
Browse files Browse the repository at this point in the history
  • Loading branch information
JanMarvin committed Oct 22, 2023
1 parent 92daf08 commit 16b5e7a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

* New set of function `wb_get_properties()`/`wb_set_properties()` to view and modify workbook properties. [782](https://github.com/JanMarvin/openxlsx2/pull/782) This was subsequently improved to handle more workbook properties like `company` and `manager`. ([799](https://github.com/JanMarvin/openxlsx2/pull/799), @olivroy)

* Basic (experimental) support to add slicers to pivot tables created by `openxlsx2`. [822](https://github.com/JanMarvin/openxlsx2/pull/822)

## Fixes

* Removing the worksheet that is the active tab does no longer result in warnings in spreadsheet software. [792](https://github.com/JanMarvin/openxlsx2/pull/792)
Expand Down
4 changes: 3 additions & 1 deletion R/class-workbook-wrappers.R
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ wb_add_pivot_table <- function(

#' Add a slicer to a pivot table
#'
#' Add a slicer to a previously created pivot table.
#' Add a slicer to a previously created pivot table. This function is still experimental and might be changed/improved in upcoming releases.
#'
#' @param wb A Workbook object containing a #' worksheet.
#' @param x A `data.frame` that inherits the [`wb_data`][wb_data()] class.
Expand All @@ -386,6 +386,8 @@ wb_add_pivot_table <- function(
#' @family workbook wrappers
#' @family worksheet content functions
#' @details This assumes that the slicer variable initialization has happened before. Unfortunately, it is unlikely that we can guarantee this for loaded workbooks, and we *strictly* discourage users from attempting this. If the variable has not been initialized properly, this may cause the spreadsheet software to crash.
#'
#' For the time being, the slicer needs to be placed on the slide with the pivot table.
#' @examples
#' wb <- wb_workbook() %>%
#' wb_add_worksheet() %>% wb_add_data(x = mtcars)
Expand Down
4 changes: 3 additions & 1 deletion man/wb_add_slicer.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 16b5e7a

Please sign in to comment.