Skip to content

Commit

Permalink
Redo pkgdown index. Remove docs for wb_hyperlink(). It was not expo…
Browse files Browse the repository at this point in the history
…rted anyway.
  • Loading branch information
olivroy committed Aug 23, 2023
1 parent 5d7668f commit 2149a15
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 21 deletions.
1 change: 0 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export(remove_comment)
export(rowcol_to_dims)
export(styles_on_sheet)
export(temp_xlsx)
export(wbChartSheet)
export(wbWorkbook)
export(wb_add_border)
export(wb_add_cell_style)
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

## Breaking changes

* no longer exporting `wb_get_sheet_name()`
* no longer exporting `wb_get_sheet_name()`, `wbChartSheet` and `wb_hyperlink()`
* deprecating `delete_data()` and minor improvements to `wb_clean_sheet()`
* removing `wb_get_worksheet()`, `wb_ws()`. These never worked as expected.
* `create_comment()` has been renamed `wb_comment()`. [758, @olivroy](https://github.com/JanMarvin/openxlsx2/pull/758) The default arguments however are changed:
Expand Down
1 change: 0 additions & 1 deletion R/class-chart-sheet.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#' @description
#' A chart sheet
#'
#' @export
wbChartSheet <- R6::R6Class(
"wbChartSheet",

Expand Down
2 changes: 1 addition & 1 deletion R/class-hyperlink.R
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ wbHyperlink <- R6::R6Class(
)

#' Create a new hyperlink object
#' @rdname Hyperlink
#' @noRd
wb_hyperlink <- function() {
wbHyperlink$new(ref = character(), target = character(), location = character())
}
Expand Down
7 changes: 6 additions & 1 deletion R/dates.R
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,13 @@ convert_to_excel_date <- function(df, date1904 = FALSE) {
df
}

#' Convert to Excel data
#'
#' Use [convert_to_excel_date()] in new code
#' @usage NULL
#' @inheritParams convert_to_excel_date
#' @keywords internal
#' @export
#' @rdname convert_to_excel_date
convertToExcelDate <- function(df, date1904 = FALSE) {
.Deprecated(old = "convertToExcelDate", new = "convert_to_excel_date", package = "openxlsx2")
convert_to_excel_date(df = df, date1904 = date1904)
Expand Down
2 changes: 0 additions & 2 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ reference:
These functions help you interact with chartsheets. They invisibly return the
wbWorkbook object. They help interact with the mschart package.
contents:
- wbChartSheet
- wb_data
- wb_add_chartsheet
- wb_add_mschart
Expand All @@ -93,7 +92,6 @@ reference:
- wb_dims
- wb_color
- wb_comment
- wb_hyperlink
- starts_with("create_")


Expand Down
11 changes: 0 additions & 11 deletions man/Hyperlink.Rd

This file was deleted.

14 changes: 14 additions & 0 deletions man/convertToExcelDate.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions man/convert_to_excel_date.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 2149a15

Please sign in to comment.