Add support for minWidth and adding defaults to avoid having comparis…

…ons to `logical(0)`
JanMarvin · Nov 14, 2023 · 2dc36f0 · 2dc36f0
1 parent fbfa9b6
commit 2dc36f0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -12,6 +12,7 @@
 
 * Improve copying cells in transpose mode and with hyperlinks. [850](https://github.com/JanMarvin/openxlsx2/pull/850)
 
+* Options `openxlsx2.maxWidth` and `openxlsx2.minWidth` are now respected as documented when setting column widths with `wb_set_col_widths()`. [847](https://github.com/JanMarvin/openxlsx2/issues/847)
 
 ***************************************************************************
 

diff --git a/R/converters.R b/R/converters.R
@@ -108,8 +108,14 @@ calc_col_width <- function(base_font, col_width) {
   # to the expected widths
   widths <- trunc((as.numeric(col_width) * mdw + 5) / mdw * 256) / 256
   widths <- round(widths, 3)
-  if (any(sel <- widths > getOption("openxlsx2.maxWidth"))) {
-    widths[sel] <- getOption("openxlsx2.maxWidth")
+
+  if (any(sel <- widths > getOption("openxlsx2.maxWidth", 250))) {
+    widths[sel] <- getOption("openxlsx2.maxWidth", 250)
+  }
+
+  if (any(sel <- widths <= getOption("openxlsx2.minWidth", 0))) {
+    widths[sel] <- getOption("openxlsx2.minWidth", 1)
   }
+
   widths
 }