[pt] Improve item selection and fix slicers names with whitespace (#842)

* [pt] pass characters to item_order * [pt] allow slicer variables to contain whitespaces
JanMarvin · Nov 8, 2023 · 53aef14 · 53aef14
1 parent f50620e
commit 53aef14
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/R/class-workbook.R b/R/class-workbook.R
@@ -1522,7 +1522,7 @@ wbWorkbook <- R6::R6Class(
       sel <- which(pt$name == pivot_table)
       cid <- pt$cacheId[sel]
 
-      uni_name <- paste0(slicer, cid)
+      uni_name <- paste0(stringi::stri_replace_all_fixed(slicer, ' ', '_'), cid)
 
       ### slicer_cache
       sortOrder <- NULL

diff --git a/R/helper-functions.R b/R/helper-functions.R
@@ -654,6 +654,8 @@ get_items <- function(data, x, item_order, slicer = FALSE, choose = NULL) {
 
   if (is.null(item_order)) {
     item_order <- order(dat)
+  } else if (is.character(item_order)) {
+    item_order <- match(dat, item_order)
   }
 
   if (!is.null(choose)) {