add dims to wb_add_conditional_formatting(). closes #654

JanMarvin · Jun 21, 2023 · 86010c1 · 86010c1
1 parent 4a9144a
commit 86010c1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/R/class-workbook-wrappers.R b/R/class-workbook-wrappers.R
@@ -2891,6 +2891,7 @@ wb_add_conditional_formatting <- function(
   assert_workbook(wb)
   wb$clone()$add_conditional_formatting(
     sheet = sheet,
+    dims  = dims,
     cols  = cols,
     rows  = rows,
     rule  = rule,

diff --git a/tests/testthat/test-conditional_formatting.R b/tests/testthat/test-conditional_formatting.R
@@ -789,4 +789,13 @@ test_that("conditional formatting with gradientFill works", {
   got <- wb$styles_mgr$styles$dxfs
   expect_equal(exp, got)
 
+  # check that the wrapper handles dims as well
+  expect_silent(
+    wb_workbook() %>%
+    wb_add_worksheet() %>%
+    wb_add_conditional_formatting(dims = "A1:B5",
+                                  type = "between",
+                                  rule = c(2, 4))
+  )
+
 })