[fmt_txt] escape xml (#757)

* [fmt_txt] escape xml fixes pteridin/flexlsx#2 (comment) * redoc
JanMarvin · Aug 23, 2023 · ff1af50 · ff1af50
1 parent fc90829
commit ff1af50
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/R/utils.R b/R/utils.R
@@ -930,7 +930,7 @@ fmt_txt <- function(
  }
 
  xml_t_attr <- if (grepl("(^\\s+)|(\\s+$)", x)) c("xml:space" = "preserve") else NULL
- xml_t <- xml_node_create("t", xml_children = x, xml_attributes = xml_t_attr)
+ xml_t <- xml_node_create("t", xml_children = replace_legal_chars(x), xml_attributes = xml_t_attr)
 
  xml_rpr <- xml_node_create(
  "rPr",

diff --git a/man/wb_add_formula.Rd b/man/wb_add_formula.Rd
diff --git a/tests/testthat/test-utils.R b/tests/testthat/test-utils.R
@@ -399,4 +399,13 @@ test_that("fmt_txt works", {
  got <- as.character(txt)
  expect_equal(exp, got)
 
+ txt <- fmt_txt("0 < 1", bold = TRUE)
+ exp <- "0 < 1"
+ got <- as.character(txt)
+ expect_equal(exp, got)
+
+ exp <- "<r><rPr><b/></rPr><t>0 &lt; 1</t></r>"
+ got <- unclass(txt)
+ expect_equal(exp, got)
+
 })