[xlsb] add data validations #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
force-pushed
the
xlsb_data_validation
branch
from
17099a2
to
45a666b
Compare
JanMarvin
force-pushed
the
xlsb_data_validation
branch
from
45a666b
to
6a3b4ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a broken test file from here: https://github.com/SheetJS/test_files/blob/master/calendar_stress_test.xlsb
Not sure why, but if I read the file as is, it reads just fine. Once the end of the file is reached, it tries to read
BrtFRTBegin- fine whateverBrtCellBlank- it looks like something went wrongBrtRowHdr- ???and here it errors out, because there is no row. I guess the file is damaged. Because the maximal amount of rows was reached Excel might have ended the file saving prematurely and it's only able to read the file, because it does some additional checks. After all, if I read the file with Excel in MS365 and save it as xlsx first and then again as xlsb,
openxlsx2is able to read the file just fine.Why do I write this? Because I wanted to read the data validation lists from an xlsb file, which is stored in the future record section (
<extLst/>) and to be able to do this, I had to remove a hack which allowed us to read the broken file.