Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.8 #1069

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Release 1.8 #1069

merged 3 commits into from
Jul 7, 2024

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Jun 29, 2024

prepare

  • roxygen2::roxygenize()
  • spelling::update_wordlist()
  • spelling::spell_check_package()
  • lintr::lint_package()
  • R CMD build openxlsx2
  • R CMD check --as-cran
  • run revdep ("most")
  • update NEWS

submission

  • First submission: 2024-07-05
Dear CRAN team,

we are aware of the NOTE regarding the use of STRING_PTR. This is caused by the Rcpp package and will be addressed with updates to Rcpp.

Best regards,
Jan Marvin Garbuszus

@JanMarvin
Copy link
Owner Author

As expected, CRAN submission complained:

package openxlsx2_1.8.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
Windows: https://win-builder.r-project.org/incoming_pretest/openxlsx2_1.8_20240705_163544/Windows/00check.log
Status: 1 NOTE
Debian: https://win-builder.r-project.org/incoming_pretest/openxlsx2_1.8_20240705_163544/Debian/00check.log
Status: 2 NOTEs

I replied with the text above and a post scriptum, that we do not use SET_POINTER() in our code. Now we have to wait.

@JanMarvin JanMarvin merged commit fa80047 into main Jul 7, 2024
13 checks passed
@JanMarvin JanMarvin deleted the 1.8 branch July 7, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant