[wb_dims] without x and non sequential rows, incorrect results were returned. fixes #1093
#1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe this should be included into the check a few lines above. There are a few things going on and obviously something unhandled slipped through and this PR feels a little hackish. |
|
It's better now that everything is in one condition, but I'm still surprised that crossing row 1 is such an issue. It's still hackish and mysteries in my code are not pleasing 😄 |
olivroy
approved these changes
Aug 5, 2024
JanMarvin
force-pushed
the
gh_issue_1093
branch
from
18a4134
to
bbf4632
Compare
|
Thanks! Rebased on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output still returns ranges, but that's acceptable. We should be able to catch this and should be able to return
A1:A1asA1.