[write] skip blanks #1111
Merged
[write] skip blanks #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We've reached number 1111 🥳 |
JanMarvin
added
enhancement 😀
|
This needs some testing with third party software like power query and the like |
JanMarvin
force-pushed
the
skip_blanks
branch
from
0dc8223
to
8fcd5c8
Compare
JanMarvin
force-pushed
the
skip_blanks
branch
from
8fcd5c8
to
4bb9795
Compare
|
@Jeff-White-AZ I've merged this with the main development branch. I'm still a bit nervous about unintended side effects like broken tables, but until it ships in a release, there's probably no way to test this fully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips blank cells entirely as discussed in #1110 .
This reduces the file size significantly for the example data provided and other sparse matrices that are thrown at
openxlsx2, but due to possible faulty impacts, this is still unlikely to be added without extensive testing.Maybe merge after the next release or never.