[dims] simplify wb_dims(). fixes #1124
#1125
Conversation
JanMarvin
force-pushed
the
gh_issue_1124
branch
from
035def9
to
b241c10
Compare
|
I have tried to clean up the existing code. All these nested conditions have given me one too many headaches. Since CRAN has not yet contacted me about the build errors in the vignette, I will postpone the next release for a while. At the moment, however, I suspect that this is a problem with the vignette or the build server. So maybe it will just go away. |
JanMarvin
force-pushed
the
gh_issue_1124
branch
4 times, most recently
from
c814e97
to
7d10b8d
Compare
| @@ -701,6 +714,9 @@ wb_dims <- function(..., select = NULL) { | |||
| names(args) <- nams | |||
| n_unnamed_args <- length(which(!nzchar(nams))) | |||
| all_args_unnamed <- n_unnamed_args == len | |||
|
|
|||
| rows_arg <- args[[rows_pos]] | |||
| cols_arg <- args[[cols_pos]] | |||
| } | |||
There was a problem hiding this comment.
Either have x or rows_arg/cols_arg.
| @@ -206,11 +206,11 @@ test_that("`wb_dims()` can select content in a nice fashion with `x`", { | |||
|
|
|||
| # Selecting a row range | |||
| dims_row1_to_5 <- "B3:L7" | |||
| expect_equal(wb_dims_cars(rows = 1:5), dims_row1_to_5) | |||
| expect_equal(wb_dims(x = mtcars, from_row = 2, from_col = "B", rows = 1:5), dims_row1_to_5) | |||
There was a problem hiding this comment.
I don't like these functions that are defined on top of a testthat file and then it breaks at the bottom, how am I supposed to know what is going on? 😅
There was a problem hiding this comment.
Yeah! While writing the tests, I was seeing if it actually worked. I should have converted the tests to standalone pieces at the end.
…, where we were working around broken input. The basic idea is that we have a single dim that can be reduced with selections of columns or rows and moved around in positive ranges.
JanMarvin
force-pushed
the
gh_issue_1124
branch
from
7d10b8d
to
b4de294
Compare
|
Rome was not built in a day, and I believe that we have already achieved a lot from humble beginnings. As you pointed out some time ago, I consider Clearing out is always easier than creating something new! Thanks for reviewing :) |
This breaks a few previously valid cases, where we were working around broken input. The basic idea is that we have a single dim that can be reduced with selections of columns or rows and moved around in positive ranges.