[vignette] add purl = FALSE to chunks using ggplot2. fixes #1073
#1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanMarvin
force-pushed
the
gh_issue_1073_pt2
branch
from
b3fdfb8
to
d844029
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in yihui/knitr#2338 this solves #1073.
Unfortunately, I can't say I fully understand the problem (and I can't say I'm a big fan of a certain party making everyone's life harder by letting people figure it out for themselves).
If the environment variable
_R_CHECK_VIGNETTES_SKIP_RUN_MAYBE_isfalse, for some reasonR CMD check openxlsx2_*throws an error with the chart vignette in sections containingggplot2(andprint()). I assume this is somehow due to the fact that theprint()statement is not available in non-interactive mode and another option would be to look forinteractive()? Anyway, this problem is hidden withR CMD check --as-cran openxlsx2_*, which disablesknitr::purl().Now for some reason the CRAN oldrel Macs are configured differently than all other machines ...
What's important to me is that the code in the vignettes is valid and works (and that I - preferably - never have to check that), so I didn't want to silence those parts entirely. Otherwise, I think it's fair to assume that no one else in the world is running R on a system configured similarly to the CRAN machines, so hopefully additional checks shouldn't be necessary.