Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] cleanup in wb_dims code and add curl to gha #1134

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

JanMarvin
Copy link
Owner

No description provided.

@JanMarvin JanMarvin force-pushed the cleanup_curl branch 3 times, most recently from 38bec44 to 85ed2d5 Compare September 12, 2024 08:22
@JanMarvin
Copy link
Owner Author

Apparently rcmdcheck::rcmdcheck() is unable to locate curl if not listed in DESCRIPTION. The only way around this (that I can think of right now) without explicitly depending on curl, would be to install curl from within the helper, but I rather like testthat to fix their ... package.

My solution with dns_lookup() is slower than curl (if curl is available), but not overbearingly slow (~3ms with curl and ~28ms with base R dns_lookup()).

@JanMarvin JanMarvin merged commit 1d336ea into main Sep 12, 2024
9 checks passed
@JanMarvin JanMarvin deleted the cleanup_curl branch September 12, 2024 09:33
@olivroy
Copy link
Collaborator

olivroy commented Sep 12, 2024

Use can specify a Config/Needs/check: curl in DESCRIPTION I think

@JanMarvin
Copy link
Owner Author

Thanks, I didn’t know that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants