Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image] add address argument to wb_add_image() #1138

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

JanMarvin
Copy link
Owner

@jistria I took the liberty to convert your PR to openxlsx2

@JanMarvin JanMarvin changed the base branch from hyperlinks_rewrite to main September 18, 2024 21:38
@jistria
Copy link

jistria commented Sep 18, 2024

Oh wow, that is very generous of you! Thank you very much for adding this feature and for letting me know! I've tried it out and it works great.

@JanMarvin
Copy link
Owner Author

Thanks for the kind words, but you did the hard work in the openxlsx PR, I just applied it here :)

Also I though it might motivate you to have a look at openxlsx2. I like to think that I have improved the openxlsx logic so much that it is worth a look. For starters, adding an image to a workbook, saving it, loading it again, and adding another image works flawlessly.

Co-authored-by: jistria <jonathon.istria@treasury.qld.gov.au>
@jistria
Copy link

jistria commented Sep 18, 2024

It has motivated me! I've been taking a closer look since then and am very happy to see features like fmt_txt(). It looks like it should be easy to make the switch!

@JanMarvin JanMarvin merged commit 6b911e6 into main Sep 18, 2024
8 of 9 checks passed
@JanMarvin JanMarvin deleted the hl_on_images branch September 18, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants