Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first part to fix the
color
/colour
mess of ours.color
orcolour
wb_colour()
In a first attempt to align the naming in
openxlsx2
I have added...
argument to (hopefully) all functions usingcolor
/colour
arguments. Every function calling one of these should trigger astandardise_color_names()
orstandardize_colour_names()
function. They convert everycolour
into acolor
argument and vice versa.In a second part we should switch our default to
color
. After all this is used by open xml under the hood. Though that will be a larger and messy search & replace PR.