-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vignettes to latest recommended API. #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor nitpicking. You can change it, but I leave this up to you. In all honesty I have to get used to the wb_dims()
part, but you are the audience the vignettes are written for. Therefore, who am I to judge 😄
Use `rows` instead of `row`
Thanks ! I addressed the comments, but realized I forgot to review most of conditional-formatting, (done now, mainly Edit: if it's too soon to advertise |
Thank you, merged! |
Remove use of
cols
, androws
to use dims instead. Add examples ofwb_dims()
usage.Address #681
I went through the vignettes to see if I could catch some more things.