Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vignettes to latest recommended API. #698

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Jul 18, 2023

Remove use of cols, and rows to use dims instead. Add examples of wb_dims() usage.
Address #681

I went through the vignettes to see if I could catch some more things.

vignettes/Update-from-openxlsx.Rmd Outdated Show resolved Hide resolved
vignettes/Update-from-openxlsx.Rmd Outdated Show resolved Hide resolved
vignettes/Update-from-openxlsx.Rmd Outdated Show resolved Hide resolved
vignettes/openxlsx2_charts_manual.Rmd Outdated Show resolved Hide resolved
vignettes/openxlsx2_style_manual.Rmd Outdated Show resolved Hide resolved
vignettes/openxlsx2_style_manual.Rmd Outdated Show resolved Hide resolved
vignettes/openxlsx2_style_manual.Rmd Outdated Show resolved Hide resolved
vignettes/openxlsx2_style_manual.Rmd Outdated Show resolved Hide resolved
vignettes/openxlsx2_style_manual.Rmd Outdated Show resolved Hide resolved
vignettes/openxlsx2_style_manual.Rmd Outdated Show resolved Hide resolved
@olivroy olivroy changed the title Cosmetic changes to vignettes. Update vignettes to latest recommended API. Jul 19, 2023
Copy link
Owner

@JanMarvin JanMarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor nitpicking. You can change it, but I leave this up to you. In all honesty I have to get used to the wb_dims() part, but you are the audience the vignettes are written for. Therefore, who am I to judge 😄

@olivroy olivroy mentioned this pull request Jul 19, 2023
@olivroy
Copy link
Collaborator Author

olivroy commented Jul 19, 2023

Thanks ! I addressed the comments, but realized I forgot to review most of conditional-formatting, (done now, mainly rows, cols to dims.

Edit: if it's too soon to advertise wb_dims(), let me know, I will just mention it once in the intro vignette.

@JanMarvin JanMarvin merged commit cda0a8e into JanMarvin:main Jul 20, 2023
@JanMarvin
Copy link
Owner

Thank you, merged!

@olivroy olivroy deleted the vignettes-examples branch July 20, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants