[wb_to_df] fix date1904 conversion #737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wb_to_df()
was not usingdate1904
detection, hence conversions viawb_to_df()
were always assuming an origin of1900-01-01
contrary to1904-01-01
. This file setting is somewhat exotic and we did provide tools to let the user detect the error, it is nevertheless a shameful mistake. Sorry.