internal: use wb_comment() in wb_add_thread + deprecations guide

[olivroy]

THis aims to help users deal better with deprecations

• Change internal to wb_comment().
• This will ensure that options(openxlsx2.soon_deprecated) works as intended and does not detect internal function use.
• An added benefit of Export wb_comment() #758 is also that comment are similar. (both accept text, although fmt_txt() is not supported in threads

just so you know, there will be some internal rework necessary to make comments "visible" but I would wait for a user request for that. #765 (comment)

I squeezed in an enhanced note on the deprecations that we can direct users to should problems arise.

No visual change before and after

Shows when hovering

Hidden when cursor is far

Edit: the openxlsx2_options name change is just that it was bugging me when navigating in files.. Saw only a single use in the pkg.

Edit2 : wb_add_thread doesn't error when not providing person_id. But it creates corrupt output (can't wb$open() after) in case you want to add protection for that.

[JanMarvin]

Thank you so much <3

[JanMarvin]

Edit2 : wb_add_thread doesn't error when not providing person_id. But it creates corrupt output (can't wb$open() after) in case you want to add protection for that.

I wanted to capture this case here. If that's not working, we might have to revisit this. But it is again midnight in Germany and it's been a long week.

openxlsx2/R/class-workbook.R

Lines 3820 to 3824 in 7b65f82

	if (missing(person_id)) {
	person_id <- getOption("openxlsx2.thread_id")
	if (is.null(person_id)) stop("no person id found")
	}