Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pugixml] update to release 1.14 #808

Merged
merged 1 commit into from
Oct 1, 2023
Merged

[pugixml] update to release 1.14 #808

merged 1 commit into from
Oct 1, 2023

Conversation

JanMarvin
Copy link
Owner

No description provided.

@JanMarvin JanMarvin merged commit 304ff1b into main Oct 1, 2023
9 checks passed
@JanMarvin JanMarvin deleted the pugixml_114 branch October 1, 2023 16:46
@olivroy
Copy link
Collaborator

olivroy commented Oct 2, 2023

I don't remember how it was before, but seeing this now when loading openxlsx2.

   xlsb.cpp:n function 'int workbook_bin(std::string, std::string, bool)
   xlsb.cpp:1609:25:warning: used variable 'fields2-Wunused-variable
    1609 |         BrtNameFields2 *fields2rtNameFields2 *)&BrtNameUint2;
         |                         ^~~~~~~
   g++ -std=gnu++17 -shared -static-libgcc -o openxlsx2.dll tmp.def RcppExports.o helper_functions.o load_workbook.o pugi.o strings_xml.o styles_xml.o write_file.o xlsb.o -LC:/rtools43/x86_64-w64-mingw32.static.posix/lib/x64 -LC:/rtools43/x86_64-w64-mingw32.static.posix/lib -LC:/PROGRA~1/R/R-43~1.1/bin/x64 -lR
   installing to C:/../AppData/Local/Temp/RtmpsRMdpM/devtools_install_6a6c5419867/00LOCK-openxlsx2/00new/openxlsx2/libs/x64

@JanMarvin
Copy link
Owner Author

Oh, that's from the xlsb part. Thanks, I'll comment this, not sure why my systems didn't catch this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants