Expose BerkeleyJE configs [tp-tests] #4701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes all BerkeleyJE configuration options to users, so that they have better control over internal settings (this functionality was requested in #1623).
Overall there is a good discussion in #1623 about deadlocks and timeouts that BerkeleyJE storage backend has. Thus, I also skimmed through the comments as well as my past tests with
BerkeleyJE
and added potential configurations suggestions based on user's feedback in documentation that may help users to get started. That said, this configuration may not fix all the issues and most likely have it's own flaws.Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: