Remove the 'visible' tags since they are causing issues on Grids and … #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…they don't seem required for good functioning.
|
It is needed for some undocumented circumstances. If you want it hidden on Xs but visible of large you need the visible css |
|
However the issue is probably that the default visible changes the display property. Standard bootstrap has multiple visible classes for various display properties. Which is not currently implemented properly. |
|
I’m not sure to follow. What I am experiencing is that nothing is changing between not using the « visible » tag and removing the code that add it when setting visibility rules on columns. So, my guess is that it does not add anything useful in the UI. I might be wrong though. It would be awesone to have feedback from other users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…they don't seem required for good functioning.
This is a proposed fix for issue #51
They 'visible' classes don't seem to add anything required, so I'm not sure why we would need them.
Feel free to discuss, I just want to find a fix for my issue.