Implementing import declarations from python through SymTableBuildPass #1344
+316
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgtm98
requested review from
kugesan1105 and
marsninja
and removed request for
kugesan1105 and
marsninja
|
@marsninja Need to check with you the import of assignment nodes. also need to check the way that I implement the rename of the decls through import aliases |
Merging main into the PR
…seci into py_import_decl_v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I implemented the ability to import Python declarations (such as classes, variables, and abilities) into Jac. This is done through
SymbolTableBuildPass, where the entire Python module specified byModulePathis added to the Jac AST. The necessary items from this module are identified and stored inpy_needed_items. DuringSymbolTableBuildPass, only these selected items are added to the symbol table.py_needed_itemsis defined as an optional dict, if it's None then the whole module is needed and the new support won't work, if the dict has a value then the specified items in the dict are only added in the symbol table.