Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JAC-CLOUD]: Improved Deserialization #1363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[JAC-CLOUD]: Improved Deserialization #1363

wants to merge 1 commit into from

Conversation

amadolid
Copy link
Collaborator

CHANGES:

  • Manually assign fields from datasource based on dataclass fields
  • Value error will be raised
    • if field is required but not existing from db
    • if field has different type from db
  • default will get populated if field has default/factory and not existing from db
  • excess fields will be included but no type checking

OLD:

  • Uses init generated by dataclass

Description

@amadolid
[JAC-CLOUD]: Improved Deserialization
d3117dc 
CHANGES:
 - Manually assign fields from datasource based on dataclass fields
 - Value error will be raised
   - if field is required but not existing from db
   - if field has different type from db
 - default will get populated if field has default/factory and not existing from db
 - excess fields will be included but no type checking

OLD:
 - Uses __init__ generated by dataclass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypkang ypkang Awaiting requested review from ypkang

@ChrisIsKing ChrisIsKing Awaiting requested review from ChrisIsKing

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amadolid