Skip to content

Commit

Permalink
Remove Unnecessary Lombok Dep and Bazel Version
Browse files Browse the repository at this point in the history
The dep on Lombok has been completely removed from the project so it's no longer necessary to reference that here. Additionally, I've finally migrated to using Bazelisk (long overdue) so I'm now able to allow Github's Bazelisk instead to reference the project's .bazelversion file naturally.

Signed-off-by: Jason Steving <32336750+JasonSteving99@users.noreply.github.com>
  • Loading branch information
JasonSteving99 committed Jul 11, 2023
1 parent c47eb2b commit 21b6299
Showing 1 changed file with 2 additions and 13 deletions.
15 changes: 2 additions & 13 deletions .github/workflows/create-new-riju-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,11 @@ jobs:
# TODO(steving) DELETE THE REST OF THIS RUN SCRIPT. THE REST OF THIS SETUP IS A LEGACY HACK JOB
# We must build the Conditions.claro program so that the necessary build artifacts are available.
# Note: This --nojava_header_compilation flag is necessary because Lombok
# fails with error "Turbine is not currently supported by lombok."
# Followed the resolution here: https://githubmemory.com/repo/rzwitserloot/lombok/issues/2911
# I don't know what any of this means.... but hey it works now *shrug*
bazel build --nojava_header_compilation //src/java/com/claro/claro_programs:conditions_compiled_claro_image
bazel build //src/java/com/claro/claro_programs:conditions_compiled_claro_image
cd bazel-bin/src/java/com/claro
# Copy the AutoValue and Lombok jar deps to the location where Riju expects them to be.
# Copy the AutoValue jar dep to the location where Riju expects it to be.
cp ../../../../external/maven/v1/https/jcenter.bintray.com/com/google/auto/value/auto-value/1.5.3/auto-value-1.5.3.jar claro_programs
cp ../../../../external/maven/v1/https/jcenter.bintray.com/org/projectlombok/lombok/1.18.20/lombok-1.18.20.jar claro_programs
# Setup a dir where Riju generated code will be placed during Riju deployment.
mkdir claro_programs/com
Expand All @@ -61,12 +56,6 @@ jobs:
# Now we finally just need to create our tarball release of the claro_programs/ dir.
tar --exclude='claro_programs/conditions_compiled_claro_image.runfiles/local_jdk' --exclude='claro_programs/conditions_compiled_claro_image.runfiles/claro-lang/external/local_jdk' -hczvf claro-lang-bazel-bin.tar.gz claro_programs/
env:
# Github Actions is using Bazelisk to keep Bazel up-to-date by default. Unfortunately I'm not doing this locally yet..
# So, in order to make sure this is building with the same version of Bazel I'm using for local development, manually
# set the version to what I'm using locally here.
# TODO(steving) In the future: upgrade to start using Bazelisk locally and then drop this.
USE_BAZEL_VERSION: 3.7.2
- name: Create Release
id: create_release
Expand Down

0 comments on commit 21b6299

Please sign in to comment.