-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make Dep Module Monomorphization Use Hermetic Java Toolchain
Previously the subprocesses were getting triggered via a direct call to `java -jar ...` which I've only now realized breaks Claro's efforts to make installing Bazel the only requirement for getting running as you'd also need to have Java installed locally before you'd be able to run any Claro programs that made use of generic procedures from dep modles. This update is a bit of a hack to ensure that supbrocesses are started using the hermetic Java toolchain provided by Bazel via the `common --java_runtime_version=remotejdk_11` flag configured in the .bazelrc. This should ensure that anyone who simply runs the `create_claro_project.sh` script will be setup to run Claro programs without any further setup necessary. I got lucky to notice this since obviously on my dev machine I already had Java installed.
- Loading branch information
1 parent
97a97c7
commit 878b557
Showing
2 changed files
with
25 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters