Skip to content

Commit

Permalink
17592 Updates for Node 20 (bcgov#544)
Browse files Browse the repository at this point in the history
- app version = 6.8.0
- updated Dockerfile
- changed vitest environment to jsdom
- updated CD script
- updated CI script
- updated PR script
- added error logging to FileUploadPdf.vue
- allowed use of env object in configuration store
- created env object for testing
- fixed obsolete "done()" in some tests
  • Loading branch information
severinbeauvais authored Sep 22, 2023
1 parent 7a00b50 commit 62a8ac3
Show file tree
Hide file tree
Showing 11 changed files with 2,613 additions and 6,640 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:

jobs:
business-filings-cd:
uses: bcgov/bcregistry-sre/.github/workflows/ui-cd.yaml@main
uses: bcgov/bcregistry-sre/.github/workflows/ui-cd-node20.yaml@main
with:
environment: ${{ inputs.environment }}
tagname: ${{ inputs.tagname }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

strategy:
matrix:
node-version: [16.14.2]
node-version: [20.5.1]

steps:
- uses: actions/checkout@v3
Expand All @@ -45,7 +45,7 @@ jobs:

strategy:
matrix:
node-version: [16.14.2]
node-version: [20.5.1]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16.14.2 as build-stage
FROM node:20.5.1 as build-stage
WORKDIR /app
COPY package*.json ./
RUN npm install
Expand Down
4 changes: 2 additions & 2 deletions devops/cloudbuild-pr.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
steps:
# install / setup ci
- name: node:16.14.2
- name: node:20.5.1
entrypoint: npm
args: ['install']

Expand All @@ -13,7 +13,7 @@ steps:
#
# Generate the static site
#
- name: node:16.14.2
- name: node:20.5.1
entrypoint: npm
env:
- 'VUE_APP_ADDRESS_COMPLETE_KEY=$_VUE_APP_ADDRESS_COMPLETE_KEY'
Expand Down
Loading

0 comments on commit 62a8ac3

Please sign in to comment.