Skip to content

Commit

Permalink
19259 - Add NR request type code for Continuation In (bcgov#652)
Browse files Browse the repository at this point in the history
* 19259 - draft continuation in-1

* 19259 - draft continuation in-2

* 19259 - misc fixes and unit tests

* 19259 - install again

* 19259 - update package version

* 19259 - update based on review

* 19259 - update to use enumUtilities

* 19259 - create a getter to show NR

* 19259 - update comments

* 19259 - add NR request type code

* 19259 - update package version
  • Loading branch information
ketaki-deodhar authored Apr 26, 2024
1 parent 30ec8b3 commit aafbac5
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "7.2.3",
"version": "7.2.4",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
2 changes: 1 addition & 1 deletion src/components/Dashboard/TodoList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -1469,7 +1469,7 @@ export default class TodoList extends Mixins(AllowableActionsMixin, DateMixin, E
continuationIn?.offices ||
continuationIn?.contactPoint ||
continuationIn?.parties ||
continuationIn?.shareStructure.shareClasses ||
continuationIn?.shareClasses ||
continuationIn?.foreignJurisdiction
)
Expand Down
3 changes: 2 additions & 1 deletion src/enums/nameRequestTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ export enum NameRequestTypes {
AMALGAMATION = 'AML',
NEW = 'NEW',
CHANGE_OF_NAME = 'CHG',
CONVERSION = 'CNV'
CONVERSION = 'CNV',
CONTINUATION_IN = 'MVE'
// Expand types here as required. Add description in getNrRequestDesc via NameRequestMixin.
}
3 changes: 2 additions & 1 deletion src/mixins/name-request-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export default class NameRequestMixin extends Vue {
if (!nr.nrNum) return 'Invalid NR number'
if (
nr.request_action_cd !== NameRequestTypes.NEW &&
nr.request_action_cd !== NameRequestTypes.AMALGAMATION
nr.request_action_cd !== NameRequestTypes.AMALGAMATION &&
nr.request_action_cd !== NameRequestTypes.CONTINUATION_IN
) return 'Invalid NR action code'
if (!nr.state) return 'Invalid NR state'
return null
Expand Down

0 comments on commit aafbac5

Please sign in to comment.