20436 Removed Intended Date field (bcgov#646)

- app version = 7.1.10
- deleted Intended Date template
- updated validity code
- updated interfaces
- deleted field from filing
- update unit tests

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>

package.json

@@ -1,6 +1,6 @@
 {
   "name": "business-filings-ui",
-  "version": "7.1.9",
+  "version": "7.1.10",
   "private": true,
   "appName": "Filings UI",
   "sbcName": "SBC Common Components",

src/components/AgmExtension/ExtensionRequest.vue

@@ -13,6 +13,7 @@
         class="px-6 py-7"
         :class="{ 'invalid-section': !firstSectionValid && showErrors }"
       >
+        <!-- first AGM? -->
         <v-row
           v-if="!is30MonthsAfterIncorp"
           no-gutters
@@ -45,6 +46,7 @@
           </v-col>
         </v-row>
 
+        <!-- AGM year -->
         <v-row no-gutters>
           <v-col
             cols="12"
@@ -74,6 +76,7 @@
         :class="{ 'invalid-section': !secondSectionValid && showErrors }"
       >
         <v-expand-transition>
+          <!-- annual reference / AGM date -->
           <v-row
             v-if="!isFirstAgm"
             no-gutters
@@ -102,6 +105,8 @@
             </v-col>
           </v-row>
         </v-expand-transition>
+
+        <!-- extension already requested? -->
         <v-row no-gutters>
           <v-col
             cols="12"
@@ -147,37 +152,6 @@
           </v-col>
         </v-row>
       </div>
-
-      <v-divider class="mx-4" />
-
-      <div
-        class="px-6 py-7"
-        :class="{ 'invalid-section': !thirdSectionValid && showErrors }"
-      >
-        <v-row no-gutters>
-          <v-col
-            cols="12"
-            sm="3"
-            class="pr-4"
-          >
-            <strong>Intended date this AGM will be held</strong>
-          </v-col>
-          <v-col
-            cols="12"
-            sm="9"
-          >
-            <DatePicker
-              class="pt-2"
-              title="Intended date this AGM will be held"
-              nudge-right="40"
-              :minDate="data.currentDate"
-              :inputRules="dateRules"
-              @emitDate="data.intendedAgmDate = $event"
-              @emitCancel="data.intendedAgmDate = ''"
-            />
-          </v-col>
-        </v-row>
-      </div>
     </template>
   </VcardTemplate>
 </template>
@@ -222,10 +196,6 @@ export default class ExtensionRequest extends Vue {
     }
   }
 
-  get thirdSectionValid (): boolean {
-    return !!this.data.intendedAgmDate
-  }
-
   /** The array of validations rule(s) for the AGM Year text field. */
   get agmYearRules (): Array<(v) => boolean | string> {
     return [
@@ -323,7 +293,6 @@ export default class ExtensionRequest extends Vue {
   @Watch('data.prevAgmDate')
   @Watch('data.isPrevExtension')
   @Watch('data.prevExpiryDate')
-  @Watch('data.intendedAgmDate')
   @Watch('data.currentDate')
   @Watch('agmYearValid')
   private onHaveChanges (): void {
@@ -497,11 +466,7 @@ export default class ExtensionRequest extends Vue {
 
   /** Whether the extension request is valid or not */
   checkValidity (): void {
-    this.isValid = (
-      this.firstSectionValid &&
-      this.secondSectionValid &&
-      this.thirdSectionValid
-    )
+    this.isValid = (this.firstSectionValid && this.secondSectionValid)
 
     this.emitValid()
   }

src/interfaces/agm-ext-eval-interface.ts

@@ -10,7 +10,6 @@ export interface AgmExtEvalIF {
   prevAgmDate: string // YYYY-MM-DD
   isPrevExtension: boolean
   prevExpiryDate: string // YYYY-MM-DD
-  intendedAgmDate: string // YYYY-MM-DD
   extensionDuration: number // in months
   agmDueDate: string // YYYY-MM-DD
   isEligible: boolean
@@ -28,7 +27,6 @@ export const EmptyAgmExtEval: AgmExtEvalIF = {
   prevAgmDate: null,
   isPrevExtension: null,
   prevExpiryDate: null,
-  intendedAgmDate: null,
   extensionDuration: NaN,
   agmDueDate: null,
   isEligible: null

src/interfaces/api-filing-interface.ts

@@ -50,7 +50,6 @@ export interface ApiFilingIF {
       prevAgmRefDate: string // YYYY-MM-DD
       extReqForAgmYear: boolean
       expireDateCurrExt: string // YYYY-MM-DD
-      intendedAgmDate: string // YYYY-MM-DD
       totalApprovedExt: number // in months
       extensionDuration: number // in months
       expireDateApprovedExt: string // YYYY-MM-DD

src/views/AgmExtension.vue

@@ -436,7 +436,6 @@ export default class AgmExtension extends Mixins(CommonMixin, DateMixin,
         year: this.data.agmYear,
         isFirstAgm: this.data.isFirstAgm,
         extReqForAgmYear: this.data.isPrevExtension,
-        intendedAgmDate: this.data.intendedAgmDate,
         totalApprovedExt: this.getTotalAgmExtensionDuration(Number(this.data.agmYear)) + this.data.extensionDuration,
         expireDateApprovedExt: this.data.agmDueDate,
         // conditionally add properties if not null
@@ -540,7 +539,6 @@ export default class AgmExtension extends Mixins(CommonMixin, DateMixin,
   @Watch('data.prevAgmDate')
   @Watch('data.isPrevExtension')
   @Watch('data.prevExpiryDate')
-  @Watch('data.intendedAgmDate')
   private onHaveChanges (): void {
     this.haveChanges = true
   }

tests/unit/AgmExtension.spec.ts

@@ -8,6 +8,7 @@ import VueRouter from 'vue-router'
 import mockRouter from './mockRouter'
 import { CorpTypeCd, FilingTypes } from '@/enums'
 import { LegalServices } from '@/services'
+import flushPromises from 'flush-promises'
 
 // components
 import AgmExtension from '@/views/AgmExtension.vue'
@@ -19,7 +20,6 @@ import { Certify } from '@/components/common'
 import { ExpandableHelp } from '@bcrs-shared-components/expandable-help'
 import ExtensionRequest from '@/components/AgmExtension/ExtensionRequest.vue'
 import SbcFeeSummary from 'sbc-common-components/src/components/SbcFeeSummary.vue'
-import flushPromises from 'flush-promises'
 
 // suppress warning "Unknown custom element <affix>" warnings
 Vue.config.silent = true
@@ -213,7 +213,6 @@ describe('AGM Extension view', () => {
         extReqForAgmYear: null,
         extensionDuration: NaN,
         incorporationDate: new Date('2000-01-01T08:00:00.000Z'),
-        intendedAgmDate: null,
         isEligible: true,
         isFirstAgm: null,
         isGoodStanding: true,

tests/unit/ExtensionRequest.spec.ts

@@ -3,7 +3,6 @@ import Vuetify from 'vuetify'
 import { mount } from '@vue/test-utils'
 import { createPinia, setActivePinia } from 'pinia'
 import ExtensionRequest from '@/components/AgmExtension/ExtensionRequest.vue'
-import { DatePicker } from '@bcrs-shared-components/date-picker'
 import { AgmExtEvalIF, EmptyAgmExtEval } from '@/interfaces'
 
 Vue.use(Vuetify)
@@ -53,10 +52,6 @@ describe('ExtensionRequest', () => {
     expect(rows.at(2).find('.col-sm-9').text())
       .toContain('Yes - Specify the date the extension expires')
     expect(rows.at(2).find('.col-sm-9').text()).toContain('No - this is the first extension request for this AGM')
-
-    // Verify intended date picker
-    expect(rows.at(3).find('.col-sm-3').text()).toBe('Intended date this AGM will be held')
-    expect(rows.at(3).find('.col-sm-9').findComponent(DatePicker).exists()).toBe(true)
   })
 
   it('displays first agm with no previous extension requested', async () => {