-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all methods of promote_type
by promote_rule
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add two very simple tests to confirm this change has no unexpected result. (There have been "obvious, non-controversial and simple" PRs in other numerical repos which did.) Then I am delighted to merge, increment the version, and release your patch. |
The comparison tests in ArbNumerics.jl/test/compare.jl Lines 10 to 57 in 1bd8472
|
yes thanks
…On Tue, Jun 11, 2024 at 10:13 PM Lars Göttgens ***@***.***> wrote:
The comparison tests in
https://github.com/JeffreySarnoff/ArbNumerics.jl/blob/1bd8472c3bfb2607a3d876fff261f11ce113dc70/test/compare.jl#L10-L57
already do a great job in testing that comparisons still hold after
promoting. Nevertheless, I added a few small tests that check the expected
output type of some basic arithmetic operations. Is this what you had in
mind?
—
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM2VRSHXQL3XBTKFIPEIFDZG5K7LAVCNFSM6AAAAABJEBBPV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGUZTENZZGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #67.