Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source index mismatch #47

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Fix source index mismatch #47

merged 1 commit into from
Dec 6, 2024

Conversation

hammannr
Copy link
Collaborator

This fixes a bug related to an index mismatch introduced in #46.
The sources were accessed according to an index that ran over the sources with shapes. They might not be the correct ones though.

In this fix, the enumeration is removed and instead, the corect source index is obtained based on the source name.

@hammannr hammannr requested a review from kdund November 16, 2024 15:19
@hammannr hammannr added the bug label Nov 16, 2024
Copy link
Collaborator

@kdund kdund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding, @hammannr , sorry for the oversight
(also I now learned the .index!)

@hammannr hammannr merged commit 6ce2095 into master Dec 6, 2024
2 checks passed
@hammannr hammannr deleted the fix_index_mismatch branch December 6, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants