-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syn requirement from 1.0.81 to 2.0.6 #251
Conversation
Updates the requirements on [syn](https://github.com/dtolnay/syn) to permit the latest version. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@1.0.81...2.0.6) --- updated-dependencies: - dependency-name: syn dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
A newer version of syn exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@JelteF @ilslv well, the problem of failing tests is dtolnay/syn#1414.
I'd vote for the option 2, despite it requires more work. This also interferes with #248. |
@tyranron I definitely vote for option 2 too. |
I think But in case they don't I think I'd prefer changing the name over impleminting our own parsing, i.e. changing the name tho |
Okay so after looking into it more, it seems that custom parsing would be fine too. As long as we only skip parsing the full list as as a meta list again. We can still use syn to parse the elements of the list though. |
Still maybe changing |
@JelteF Regarding custom parsing - I don't see this as a minus. Outside I will try to finish this PR in next few days. |
Alrigth sounds good, let's go with the custom parsing for |
@tyranron friendly ping :). I feel like we're super close to releasing 1.0 |
@JelteF I'm super sorry, have been so overwhelmed on my job last weeks that couldn't even touch it. Now it seems I start getting some time for open source again, and getting I've implemented minimal polyfill for parsing |
@JelteF ping 🙃 |
@JelteF ping |
Updates the requirements on syn to permit the latest version.
Commits
7840102
Release 2.0.6e76d644
Merge pull request #1420 from dtolnay/nonbracemacro6dcc480
Keep non-brace macro invocations in trailing expr position as Expr::Macrod12db40
Merge pull request #1419 from dtolnay/expectedsemi69c5efc
Improve error message on missing ';' between statementsfd18254
Release 2.0.54df4c4e
Merge pull request #1417 from dtolnay/exprmacrof591c40
Provide Expr::Macro even with features="full" offfb1062f
Eliminate allow_struct args in non-full mode99de683
Factor out Path::is_mod_style private methodYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Fixes #249 > Note