Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy errors in tests #370

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix clippy errors in tests #370

merged 2 commits into from
Jun 17, 2024

Conversation

JelteF
Copy link
Owner

@JelteF JelteF commented Jun 15, 2024

Synopsis

We were only running clippy on our normal code, not tests or examples.

Solution

This starts running clippy on the full codebase by using --all-targets. It
also fixes all issues that this flag found.

@JelteF JelteF enabled auto-merge (squash) June 15, 2024 17:26
@tyranron tyranron added this to the 1.0.0 milestone Jun 17, 2024
Copy link
Collaborator

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JelteF I've taken a bit of initiative over your work and did the following adjustments:

  1. Reverted removing in tests this line

    #[cfg(not(msrv))] // TODO: Remove once MSRV bumps 1.66 or higher.

    Since we're still on 1.65 MSRV and removal failed the CI.

  2. Added brief comments to almost all #[allow(..)] usage in the code. This is something I've started doing recently in the crates I support, because it helps me to reconsider them much quicker when tuning lints for newer Rust versions. When I search for them in the IDE, it looks like this:

Screenshot 2024-06-17 at 12 30 14

@JelteF JelteF merged commit cf842e9 into master Jun 17, 2024
17 checks passed
@JelteF JelteF deleted the fix-clippy-tests branch June 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants