Work around bug in rust-analyzer to make auto-imports work nicely #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It starts to feel like we're doing hack upon hack here, but ah well, this seems to work.
JelteF
force-pushed
the
fix-rust-analyzer-auto-imports
branch
from
8584a61
to
6d4f192
Compare
|
To clarify I spent quite some time to try address this problem in rust-analyzer first, but that turned out not to be an easy task. So I gave up and implemented this workaround instead. |
tyranron
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #351
Synopsis
Rust-analyzer doesn't ignore
#[doc(hidden)]exports when they use a globpattern, only when they explicitely re-export.
Solution
This adds more level of indirection and one more glob pattern so that we put
#[doc(hidden)]on explicit re-exports. This definitely starts to feel likewe're doing hack upon hack here. But ah well, this seems to work. And working
well with the most popular LSP for Rust seems worth a bit of a hack.