Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration Sector Cleanup #46

Merged
merged 26 commits into from
Jun 24, 2024
Merged

Configuration Sector Cleanup #46

merged 26 commits into from
Jun 24, 2024

Conversation

IanTapply22
Copy link
Member

Description

Made some balloon fields optional, cleaned up the configuration sector, and reworked how the configuration system works

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on a version 1.20.4 PaperMC Minecraft server

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, if any
  • My changes generate no new warnings
  • I have performed tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes

IanTapply22 added 20 commits June 21, 2024 19:07
Create example configurations for balloons
2ce5314 
Add model engine as a dependency in pom.xml
Remove multipart example config
66c7b06
Merge branch 'main' into meg-implementation
0024b65
Create a basic implementation of MEG
55a53ce
Remove unused single balloon type vars
199eb36
Fix log of material not dyeable to only trigger on non-MEG balloons
0665d74
Fix warning messages of config file already existing
4642438
Implement idle animations
8e21026
Remove armor stand debug visibility
1d8fde3
Mess around with MEG dummies
039f730
Revert changes of using dummies
bc0775c
Created the configurations and the fetching of them
63e9dcc
Set default balloon height to be 2.0
5e6b75b
Fully comment the single balloon type class
70be6f4
Rearranged the methods in SingleBalloon
e6e377d
Move example balloons out of the method for copying example balloons
62f926e
Clean up basic code structure of the balloon directory
25356c4
Remove more unused code and commented more variables
f4bb51c
Rename variables to make more sense and renamed classes
d66d278
Made fields optional for a multipart balloon types
2d77350
@IanTapply22 IanTapply22 added the enhancement New feature or request label Jun 23, 2024
@IanTapply22 IanTapply22 self-assigned this Jun 23, 2024
@IanTapply22 IanTapply22 merged commit 73d3bed into main Jun 24, 2024
4 checks passed
@IanTapply22 IanTapply22 deleted the configuration-sector-cleanup branch June 24, 2024 01:32
@IanTapply22 IanTapply22 mentioned this pull request Jun 24, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IanTapply22 IanTapply22

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IanTapply22