-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add elastic8 support #253
Add elastic8 support #253
Conversation
1391aeb
to
7583f71
Compare
da264f5
to
1892e14
Compare
@blackshadev I have this issue when trying to persist a model in the database that uses the "Searchable" trait. Is this the problem you say you solve? "Driver [explorer] not supported." |
No. This PR will not solve any problem. It is a upgrade to elastic 8 |
Looks pretty good, did some more cleaning up as well. Only could not yet get the demo app working (merged the PR and main should be on Laravel 11 now). |
Any logs from the elastic stack to share. I have some reproduction steps for you.
I tried your branches but I couldn't get composer install to work. Did you have the same problem? |
After allot of trail and error. This is the composer.json with which I could install laravel 11 on the demo app. I did end up needing to remove the fruitcake cors package (it should be build in now). And I needed to upgrade phpunit :( See this MR
|
Thank you for these efforts |
Two things I have added to my provider you may want to add to your builder in
|
I'd like to keep this PR focussed on soly the upgrade, while not adding any features. If this is merged we van add it no problem. But at least this way there is a elastic-8 version out there as fast as possible. |
Understood. Did you confirm the logger works? I think that's an existing feature, this was the only way I was able to keep backwards compatible. |
Didn't double check, but it should work fine. According to ours docs you need to set |
Shipping time |
This has one two breaking changes:
selector
namespace has changed, I updated the docs as such.TODO