Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new samples, HelloScreen and HelloTriangle #133

Merged
merged 14 commits into from
Jun 12, 2024
Merged

Conversation

JessyDL
Copy link
Owner

@JessyDL JessyDL commented Jun 10, 2024

This PR adds sorely missing examples. They will show best practices, and will ease readers into understanding the core architecture.

Additionally some minor bugs were fixed such as:

  • psl::library had competing default constructors
  • psl::library had issues when constructing without a backed physical library file
  • transforming a path to the windows version would lead to a crash if the path was 0 sized.

Minor new features:

  • cmake targets can now specify a sub-directory for where the binary goes

@JessyDL JessyDL marked this pull request as ready for review June 12, 2024 20:32
@JessyDL JessyDL merged commit ab99b18 into develop Jun 12, 2024
14 checks passed
@JessyDL JessyDL deleted the jdl/samples branch June 12, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant