fix: EXPOSED-576 DAO Entity.new() fails if there is column with default va… #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue and transformation
bog-walk
approved these changes
Oct 2, 2024
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/ColumnType.kt
Outdated
Show resolved
Hide resolved
exposed-core/src/main/kotlin/org/jetbrains/exposed/sql/ResultRow.kt
Outdated
Show resolved
Hide resolved
obabichevjb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change:
This PR fixes an issue with
DAO Entity.new()when dealing with columns that have default values and transformations. It modifies how theResultRowis populated with default values to ensure that base types are stored rather than transformed values.Detailed description:
What:
ResultRow.createAndFillDefaults()method to handle default values with transformations more effectively. It now ensures that the unwrapped base types are stored in theResultRow.originalColumnTypeto theColumnWithTransformclass to access the base column typeHow:
ResultRow.createAndFillDefaults(), it unwraps the transformed values before they are set in the row. TheunwrapRecursivemethod ensures that nested transformations are properly unwrapped.Type of Change
Affected databases:
Related Issues
EXPOSED-576 DAO Entity.new() fails if there is column with default value and transformation
EXPOSED-574 NPE when using a nullable ColumnWithTransform with default