refactor: pass in logger to service so caller can control logs #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
requested changes
Sep 10, 2024
This reverts commit 1259af8.
sbruens
force-pushed
the
sbruens/logger
branch
from
63881cc
to
a233867
Compare
fortuna
reviewed
Sep 16, 2024
sbruens
force-pushed
the
sbruens/logger
branch
2 times, most recently
from
b6621e2
to
b7bbfa0
Compare
sbruens
force-pushed
the
sbruens/logger
branch
from
b7bbfa0
to
7480f3c
Compare
sbruens
force-pushed
the
sbruens/logger
branch
from
b9088ec
to
fd04a2b
Compare
fortuna
reviewed
Sep 16, 2024
fortuna
reviewed
Sep 16, 2024
sbruens
force-pushed
the
sbruens/logger
branch
from
d82c79f
to
9b1b801
Compare
fortuna
reviewed
Sep 20, 2024
…don't need a zap adapter for Caddy.
fortuna
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generally good practice so the caller has more control over logging (and can decide to drop logging altogether), but specifically will allow us to inject a Caddy logger in a forthcoming PR where we introduce a Caddy module.