only clear when verify sig

JimmyShi22 · Sep 11, 2023 · 3431682 · 3431682
1 parent 98b519e
commit 3431682
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/bcos-tars-protocol/bcos-tars-protocol/protocol/TransactionFactoryImpl.h b/bcos-tars-protocol/bcos-tars-protocol/protocol/TransactionFactoryImpl.h
@@ -69,11 +69,11 @@ class TransactionFactoryImpl : public bcos::protocol::TransactionFactory
             BOOST_THROW_EXCEPTION(std::invalid_argument("transaction hash mismatching"));
         }
 
-        transaction->mutableInner().sender.clear();  // Bugfix: User will fake a illegal sender,
-                                                     // must clear sender given by rpc
-
         if (checkSig)
         {
+            transaction->mutableInner().sender.clear();  // Bugfix: User will fake a illegal sender,
+            // must clear sender given by rpc
+
             transaction->verify(*m_cryptoSuite->hashImpl(), *m_cryptoSuite->signatureImpl());
         }
         return transaction;