Strip most logs in the release version #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the release version, we remove some logs (except error level) added into the injected process. This helps to leave fewer unnecessary logs which are impossible for modules to hide. This function can be toggled using the static field `beSilent`. Developers are encouraged to use the debug version of LSPosed to develop modules.
|
Can't express enough ❤️ |
We use the verbose log toggle to control if logs are stripped
|
Instead of alway stripping logs in the release version, now users can control it from the manager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that it is not easy for module developers to hide logs of LSPosed from apps, I am stripping logs from LSPosed in the release version.
Please leave your comments here on this decision.
Technical details:
beSilentof classorg.lsposed.lspd.util.Utils.Log.XposedBridge.logand any error logs aren't and will never be stripped