Bevy 0.14 update #60
Merged
Bevy 0.14 update #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason this is just sitting here? 👍 |
|
I've been busy with IRL stuff -- I'll see if I have time to merge this this weekend |
|
Any updates? |
|
@cuppachino I talked to jojojet and now I'm co-maintaining the crate. I'll try to get a proper release for 0.14 up to crates.io before 0.15 hits the surface. Also I'm already working on the 0.15 update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of solves #59 I'm not sure if the added test actually tests the UB but it seems to pass on my machine without panics. I'll double check it though. Update: It looks like the panic is only hit if we transmute to something which includes one of the
bevy-trait-querycomponent types (OneorAll). I added an additional test which highlights this. There's also an explicit panic inbevy-trait-querynow which will guide users to the issue which causes the trouble and which provides minimal help.For performance differences, see this comment: #59 (comment) (TLDR:
Allperformance improves,Oneperformance regresses)