chore(meta): improve documentation, comments, doctests for dx #155
Jon-BeckerAnnotations
4 errors and 8 warnings
|
doctest
Process completed with exit code 101.
|
|
test ubuntu-latest
Process completed with exit code 100.
|
|
test macos-latest
The job was canceled because "ubuntu-latest" failed.
|
|
test macos-latest
The operation was canceled.
|
|
clippy:
common/src/utils/io/logging.rs#L111
[clippy] reported by reviewdog 🐶
<pre><code>warning: accessing first element with `trace.message.get(0)`
--> common/src/utils/io/logging.rs:111:21
|
111 | trace.message.get(0).expect("Failed to build trace.")
| ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
</code></pre>
Raw Output:
common/src/utils/io/logging.rs:111:21:w:
<pre><code>warning: accessing first element with `trace.message.get(0)`
--> common/src/utils/io/logging.rs:111:21
|
111 | trace.message.get(0).expect("Failed to build trace.")
| ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
</code></pre>
__END__
|
|
clippy:
common/src/utils/io/logging.rs#L139
[clippy] reported by reviewdog 🐶
<pre><code>warning: accessing first element with `trace.message.get(0)`
--> common/src/utils/io/logging.rs:139:21
|
139 | trace.message.get(0).expect("Failed to build trace.")
| ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
</code></pre>
Raw Output:
common/src/utils/io/logging.rs:139:21:w:
<pre><code>warning: accessing first element with `trace.message.get(0)`
--> common/src/utils/io/logging.rs:139:21
|
139 | trace.message.get(0).expect("Failed to build trace.")
| ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
</code></pre>
__END__
|
|
clippy:
common/src/utils/io/logging.rs#L214
[clippy] reported by reviewdog 🐶
<pre><code>warning: accessing first element with `trace.message.get(0)`
--> common/src/utils/io/logging.rs:214:21
|
214 | trace.message.get(0).expect("Failed to build trace.")
| ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
</code></pre>
Raw Output:
common/src/utils/io/logging.rs:214:21:w:
<pre><code>warning: accessing first element with `trace.message.get(0)`
--> common/src/utils/io/logging.rs:214:21
|
214 | trace.message.get(0).expect("Failed to build trace.")
| ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
</code></pre>
__END__
|
|
clippy:
core/src/decompile/analyzers/yul.rs#L410
[clippy] reported by reviewdog 🐶
<pre><code>warning: you seem to use `.enumerate()` and immediately discard the index
--> core/src/decompile/analyzers/yul.rs:410:23
|
410 | for (_, child) in vm_trace.children.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
|
410 | for child in vm_trace.children.iter() {
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
</code></pre>
Raw Output:
core/src/decompile/analyzers/yul.rs:410:23:w:
<pre><code>warning: you seem to use `.enumerate()` and immediately discard the index
--> core/src/decompile/analyzers/yul.rs:410:23
|
410 | for (_, child) in vm_trace.children.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
= note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
|
410 | for child in vm_trace.children.iter() {
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
</code></pre>
__END__
|
|
clippy:
core/src/decompile/out/solidity.rs#L27
[clippy] reported by reviewdog 🐶
<pre><code>warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> core/src/decompile/out/solidity.rs:27:10
|
27 | abi: &Vec<ABIStructure>,
| ^^^^^^^^^^^^^^^^^^ help: change this to: `&[ABIStructure]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
</code></pre>
Raw Output:
core/src/decompile/out/solidity.rs:27:10:w:
<pre><code>warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> core/src/decompile/out/solidity.rs:27:10
|
27 | abi: &Vec<ABIStructure>,
| ^^^^^^^^^^^^^^^^^^ help: change this to: `&[ABIStructure]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
</code></pre>
__END__
|
|
clippy:
core/src/decompile/resolve.rs#L22
[clippy] reported by reviewdog 🐶
<pre><code>warning: accessing first element with `types.get(0)`
--> core/src/decompile/resolve.rs:22:35
|
22 | .map(|(_, types)| types.get(0).unwrap().clone())
| ^^^^^^^^^^^^ help: try: `types.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
</code></pre>
Raw Output:
core/src/decompile/resolve.rs:22:35:w:
<pre><code>warning: accessing first element with `types.get(0)`
--> core/src/decompile/resolve.rs:22:35
|
22 | .map(|(_, types)| types.get(0).unwrap().clone())
| ^^^^^^^^^^^^ help: try: `types.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
</code></pre>
__END__
|
|
clippy:
core/src/snapshot/analyze.rs#L531
[clippy] reported by reviewdog 🐶
<pre><code>warning: you seem to use `.enumerate()` and immediately discard the index
--> core/src/snapshot/analyze.rs:531:23
|
531 | for (_, child) in vm_trace.children.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
help: remove the `.enumerate()` call
|
531 | for child in vm_trace.children.iter() {
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
</code></pre>
Raw Output:
core/src/snapshot/analyze.rs:531:23:w:
<pre><code>warning: you seem to use `.enumerate()` and immediately discard the index
--> core/src/snapshot/analyze.rs:531:23
|
531 | for (_, child) in vm_trace.children.iter().enumerate() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
help: remove the `.enumerate()` call
|
531 | for child in vm_trace.children.iter() {
| ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~
</code></pre>
__END__
|
|
clippy:
core/src/snapshot/resolve.rs#L23
[clippy] reported by reviewdog 🐶
<pre><code>warning: accessing first element with `types.get(0)`
--> core/src/snapshot/resolve.rs:23:35
|
23 | .map(|(_, types)| types.get(0).unwrap().clone())
| ^^^^^^^^^^^^ help: try: `types.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
</code></pre>
Raw Output:
core/src/snapshot/resolve.rs:23:35:w:
<pre><code>warning: accessing first element with `types.get(0)`
--> core/src/snapshot/resolve.rs:23:35
|
23 | .map(|(_, types)| types.get(0).unwrap().clone())
| ^^^^^^^^^^^^ help: try: `types.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
</code></pre>
__END__
|