Skip to content

chore(meta): improve documentation, comments, doctests for dx #160

chore(meta): improve documentation, comments, doctests for dx

chore(meta): improve documentation, comments, doctests for dx #160

Triggered via pull request November 17, 2023 03:19
Status Failure
Total duration 4m 38s
Artifacts

tests.yml

on: pull_request
Matrix: test
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 7 warnings
test ubuntu-latest
Process completed with exit code 100.
test macos-latest
The job was canceled because "ubuntu-latest" failed.
test macos-latest
The operation was canceled.
clippy: common/src/utils/io/logging.rs#L111
[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `trace.message.get(0)` --> common/src/utils/io/logging.rs:111:21 | 111 | trace.message.get(0).expect("Failed to build trace.") | ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default </code></pre> Raw Output: common/src/utils/io/logging.rs:111:21:w: <pre><code>warning: accessing first element with `trace.message.get(0)` --> common/src/utils/io/logging.rs:111:21 | 111 | trace.message.get(0).expect("Failed to build trace.") | ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default </code></pre> __END__
clippy: common/src/utils/io/logging.rs#L139
[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `trace.message.get(0)` --> common/src/utils/io/logging.rs:139:21 | 139 | trace.message.get(0).expect("Failed to build trace.") | ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> Raw Output: common/src/utils/io/logging.rs:139:21:w: <pre><code>warning: accessing first element with `trace.message.get(0)` --> common/src/utils/io/logging.rs:139:21 | 139 | trace.message.get(0).expect("Failed to build trace.") | ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> __END__
clippy: common/src/utils/io/logging.rs#L214
[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `trace.message.get(0)` --> common/src/utils/io/logging.rs:214:21 | 214 | trace.message.get(0).expect("Failed to build trace.") | ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> Raw Output: common/src/utils/io/logging.rs:214:21:w: <pre><code>warning: accessing first element with `trace.message.get(0)` --> common/src/utils/io/logging.rs:214:21 | 214 | trace.message.get(0).expect("Failed to build trace.") | ^^^^^^^^^^^^^^^^^^^^ help: try: `trace.message.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> __END__
clippy: core/src/decompile/analyzers/yul.rs#L420
[clippy] reported by reviewdog 🐶 <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/decompile/analyzers/yul.rs:420:23 | 420 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 420 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> Raw Output: core/src/decompile/analyzers/yul.rs:420:23:w: <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/decompile/analyzers/yul.rs:420:23 | 420 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 420 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> __END__
clippy: core/src/decompile/resolve.rs#L24
[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `types.get(0)` --> core/src/decompile/resolve.rs:24:35 | 24 | .map(|(_, types)| types.get(0).unwrap().clone()) | ^^^^^^^^^^^^ help: try: `types.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default </code></pre> Raw Output: core/src/decompile/resolve.rs:24:35:w: <pre><code>warning: accessing first element with `types.get(0)` --> core/src/decompile/resolve.rs:24:35 | 24 | .map(|(_, types)| types.get(0).unwrap().clone()) | ^^^^^^^^^^^^ help: try: `types.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default </code></pre> __END__
clippy: core/src/snapshot/analyze.rs#L531
[clippy] reported by reviewdog 🐶 <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/snapshot/analyze.rs:531:23 | 531 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index help: remove the `.enumerate()` call | 531 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> Raw Output: core/src/snapshot/analyze.rs:531:23:w: <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/snapshot/analyze.rs:531:23 | 531 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index help: remove the `.enumerate()` call | 531 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> __END__
clippy: core/src/snapshot/resolve.rs#L25
[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `types.get(0)` --> core/src/snapshot/resolve.rs:25:35 | 25 | .map(|(_, types)| types.get(0).unwrap().clone()) | ^^^^^^^^^^^^ help: try: `types.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> Raw Output: core/src/snapshot/resolve.rs:25:35:w: <pre><code>warning: accessing first element with `types.get(0)` --> core/src/snapshot/resolve.rs:25:35 | 25 | .map(|(_, types)| types.get(0).unwrap().clone()) | ^^^^^^^^^^^^ help: try: `types.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> __END__