[clippy] reported by reviewdog 🐶 <pre><code>warning: parameter is only used in recursion --> common/src/ether/evm/ext/exec/mod.rs:70:9 | 70 | logger: &Logger, | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_logger` | note: parameter used here --> common/src/ether/evm/ext/exec/mod.rs:242:25 | 242 | logger, | ^^^^^^ ... 246 | vm_trace.children.push(vm.recursive_map(branch_count, handled_jumps, logger)); | ^^^^^^ ... 255 | logger, | ^^^^^^ ... 259 | vm_trace.children.push(vm.recursive_map(branch_count, handled_jumps, logger)); | ^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion = note: `#[warn(clippy::only_used_in_recursion)]` on by default </code></pre> Raw Output: common/src/ether/evm/ext/exec/mod.rs:70:9:w: <pre><code>warning: parameter is only used in recursion --> common/src/ether/evm/ext/exec/mod.rs:70:9 | 70 | logger: &Logger, | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_logger` | note: parameter used here --> common/src/ether/evm/ext/exec/mod.rs:242:25 | 242 | logger, | ^^^^^^ ... 246 | vm_trace.children.push(vm.recursive_map(branch_count, handled_jumps, logger)); | ^^^^^^ ... 255 | logger, | ^^^^^^ ... 259 | vm_trace.children.push(vm.recursive_map(branch_count, handled_jumps, logger)); | ^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion = note: `#[warn(clippy::only_used_in_recursion)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: writing `&String` instead of `&str` involves a new object where a slice will do --> common/src/utils/strings.rs:363:36 | 363 | pub fn get_shortned_target(target: &String) -> String { | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default help: change this to | 363 ~ pub fn get_shortned_target(target: &str) -> String { 364 ~ let mut shortened_target = target.to_owned(); | </code></pre> Raw Output: common/src/utils/strings.rs:363:36:w: <pre><code>warning: writing `&String` instead of `&str` involves a new object where a slice will do --> common/src/utils/strings.rs:363:36 | 363 | pub fn get_shortned_target(target: &String) -> String { | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default help: change this to | 363 ~ pub fn get_shortned_target(target: &str) -> String { 364 ~ let mut shortened_target = target.to_owned(); | </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/decompile/analyzers/yul.rs:420:23 | 420 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 420 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> Raw Output: core/src/decompile/analyzers/yul.rs:420:23:w: <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/decompile/analyzers/yul.rs:420:23 | 420 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 420 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> __END__