reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085

reviewdog exited with status code: 1

[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `diff.get(0)` --> common/src/ether/evm/ext/exec/util.rs:199:39 | 199 | if !stack_diffs.iter().all(|diff| diff.get(0) == stack_diffs.get(0).unwrap_or(&vec![]).get(0)) { | ^^^^^^^^^^^ help: try: `diff.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default </code></pre> Raw Output: common/src/ether/evm/ext/exec/util.rs:199:39:w: <pre><code>warning: accessing first element with `diff.get(0)` --> common/src/ether/evm/ext/exec/util.rs:199:39 | 199 | if !stack_diffs.iter().all(|diff| diff.get(0) == stack_diffs.get(0).unwrap_or(&vec![]).get(0)) { | ^^^^^^^^^^^ help: try: `diff.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `stack_diffs.get(0).unwrap_or(&vec![]).get(0)` --> common/src/ether/evm/ext/exec/util.rs:199:54 | 199 | if !stack_diffs.iter().all(|diff| diff.get(0) == stack_diffs.get(0).unwrap_or(&vec![]).get(0)) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stack_diffs.get(0).unwrap_or(&vec![]).first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> Raw Output: common/src/ether/evm/ext/exec/util.rs:199:54:w: <pre><code>warning: accessing first element with `stack_diffs.get(0).unwrap_or(&vec![]).get(0)` --> common/src/ether/evm/ext/exec/util.rs:199:54 | 199 | if !stack_diffs.iter().all(|diff| diff.get(0) == stack_diffs.get(0).unwrap_or(&vec![]).get(0)) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stack_diffs.get(0).unwrap_or(&vec![]).first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: accessing first element with `stack_diffs.get(0)` --> common/src/ether/evm/ext/exec/util.rs:199:54 | 199 | if !stack_diffs.iter().all(|diff| diff.get(0) == stack_diffs.get(0).unwrap_or(&vec![]).get(0)) { | ^^^^^^^^^^^^^^^^^^ help: try: `stack_diffs.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> Raw Output: common/src/ether/evm/ext/exec/util.rs:199:54:w: <pre><code>warning: accessing first element with `stack_diffs.get(0)` --> common/src/ether/evm/ext/exec/util.rs:199:54 | 199 | if !stack_diffs.iter().all(|diff| diff.get(0) == stack_diffs.get(0).unwrap_or(&vec![]).get(0)) { | ^^^^^^^^^^^^^^^^^^ help: try: `stack_diffs.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: this boolean expression can be simplified --> common/src/utils/range_map.rs:110:9 | 110 | / (incoming.start <= incumbent.start && incoming.end >= incumbent.end) || 111 | | (incoming.start <= incumbent.start && incoming.end >= incumbent.start) || 112 | | (incoming.start <= incumbent.end && incoming.end >= incumbent.end) || 113 | | (incoming.start > incumbent.start && incoming.end < incumbent.end) | |______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `#[warn(clippy::nonminimal_bool)]` on by default help: try | 110 | !(incoming.start <= incumbent.start && incoming.end < incumbent.end && incoming.end < incumbent.start || incoming.start > incumbent.start && incoming.end >= incumbent.end && incoming.start > incumbent.end) | 110 | (incoming.start <= incumbent.end || incoming.end < incumbent.end || incoming.start <= incumbent.start) && (incoming.end >= incumbent.start || incoming.end >= incumbent.end || incoming.start > incumbent.start) | </code></pre> Raw Output: common/src/utils/range_map.rs:110:9:w: <pre><code>warning: this boolean expression can be simplified --> common/src/utils/range_map.rs:110:9 | 110 | / (incoming.start <= incumbent.start && incoming.end >= incumbent.end) || 111 | | (incoming.start <= incumbent.start && incoming.end >= incumbent.start) || 112 | | (incoming.start <= incumbent.end && incoming.end >= incumbent.end) || 113 | | (incoming.start > incumbent.start && incoming.end < incumbent.end) | |______________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool = note: `#[warn(clippy::nonminimal_bool)]` on by default help: try | 110 | !(incoming.start <= incumbent.start && incoming.end < incumbent.end && incoming.end < incumbent.start || incoming.start > incumbent.start && incoming.end >= incumbent.end && incoming.start > incumbent.end) | 110 | (incoming.start <= incumbent.end || incoming.end < incumbent.end || incoming.start <= incumbent.start) && (incoming.end >= incumbent.start || incoming.end >= incumbent.end || incoming.start > incumbent.start) | </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: this boolean expression can be simplified --> common/src/utils/range_map.rs:110:9 | 110 | / (incoming.start <= incumbent.start && incoming.end >= incumbent.end) || 111 | | (incoming.start <= incumbent.start && incoming.end >= incumbent.start) || | |__________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool help: try | 110 | !(incoming.start > incumbent.start || incoming.end < incumbent.end && incoming.end < incumbent.start) || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 110 | (incoming.end >= incumbent.start || incoming.end >= incumbent.end) && incoming.start <= incumbent.start || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> Raw Output: common/src/utils/range_map.rs:110:9:w: <pre><code>warning: this boolean expression can be simplified --> common/src/utils/range_map.rs:110:9 | 110 | / (incoming.start <= incumbent.start && incoming.end >= incumbent.end) || 111 | | (incoming.start <= incumbent.start && incoming.end >= incumbent.start) || | |__________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool help: try | 110 | !(incoming.start > incumbent.start || incoming.end < incumbent.end && incoming.end < incumbent.start) || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 110 | (incoming.end >= incumbent.start || incoming.end >= incumbent.end) && incoming.start <= incumbent.start || | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/decompile/analyzers/yul.rs:420:23 | 420 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 420 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> Raw Output: core/src/decompile/analyzers/yul.rs:420:23:w: <pre><code>warning: you seem to use `.enumerate()` and immediately discard the index --> core/src/decompile/analyzers/yul.rs:420:23 | 420 | for (_, child) in vm_trace.children.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `#[warn(clippy::unused_enumerate_index)]` on by default help: remove the `.enumerate()` call | 420 | for child in vm_trace.children.iter() { | ~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~ </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: using `if let` to pattern match a bool --> core/src/decompile/out/postprocessers/solidity.rs:235:8 | 235 | if let true = found_match { | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using the condition directly: `found_match` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default </code></pre> Raw Output: core/src/decompile/out/postprocessers/solidity.rs:235:8:w: <pre><code>warning: using `if let` to pattern match a bool --> core/src/decompile/out/postprocessers/solidity.rs:235:8 | 235 | if let true = found_match { | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using the condition directly: `found_match` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: using `if let` to pattern match a bool --> core/src/decompile/out/postprocessers/solidity.rs:302:8 | 302 | if let true = matched_loc.2 { | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using the condition directly: `matched_loc.2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching </code></pre> Raw Output: core/src/decompile/out/postprocessers/solidity.rs:302:8:w: <pre><code>warning: using `if let` to pattern match a bool --> core/src/decompile/out/postprocessers/solidity.rs:302:8 | 302 | if let true = matched_loc.2 { | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using the condition directly: `matched_loc.2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching </code></pre> __END__

[clippy] reported by reviewdog 🐶 <pre><code>warning: using `if let` to pattern match a bool --> core/src/decompile/out/postprocessers/solidity.rs:341:8 | 341 | if let true = matched_loc.2 { | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using the condition directly: `matched_loc.2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching </code></pre> Raw Output: core/src/decompile/out/postprocessers/solidity.rs:341:8:w: <pre><code>warning: using `if let` to pattern match a bool --> core/src/decompile/out/postprocessers/solidity.rs:341:8 | 341 | if let true = matched_loc.2 { | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using the condition directly: `matched_loc.2` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching </code></pre> __END__